Skip to content

Confirm Watch dashboard actions - #412

Merged
utkarsh232005 merged 4 commits into
KDM-cli:mainfrom
utkarsh232005:fix/252-watch-confirmation
Nov 13, 2026
Merged

Confirm Watch dashboard actions#412
utkarsh232005 merged 4 commits into
KDM-cli:mainfrom
utkarsh232005:fix/252-watch-confirmation

Conversation

@utkarsh232005

@utkarsh232005 utkarsh232005 commented Nov 13, 2026

Copy link
Copy Markdown
Member

Summary

  • Let b close the logs overlay and label fetched logs as a snapshot.
  • Require confirmation before deleting a Pod or restarting a container.
  • Describe Pod deletion without assuming a controller will recreate it.

Closes #252

Copilot AI balanced review requested due to automatic review settings November 13, 2026 16:33
Copilot AI reviewed Nov 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 32 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: QUIET
  • Plan: Advanced
  • Run ID: 8c0f9ebb-e691-4a26-8e09-57d01ba0bea2
Commits

Reviewing files that changed from the base of the PR and between eb531ba and 685f10c.

Files selected for processing: 2

  • src/__tests__/watch-dashboard-actions.test.tsx
  • src/ui/WatchDashboard.tsx

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

Parsing errors: 2 

Validation error: Invalid input: expected string, received undefined at "reviews.path_instructions[3].path"; Invalid input: expected string, received undefined at "reviews.path_instructions[3].instructions"
Configuration instructions

  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@codecov

codecov Bot commented Nov 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ui/WatchDashboard.tsx 77.77% 0 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

Copilot AI balanced review requested due to automatic review settings November 13, 2026 16:52
Copilot AI reviewed Nov 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

codescene-delta-analysis[bot]

This comment was marked as outdated.

Sign in to view

Copilot AI balanced review requested due to automatic review settings November 13, 2026 16:54
Copilot AI reviewed Nov 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

codescene-delta-analysis[bot]

This comment was marked as outdated.

Sign in to view

Copilot AI balanced review requested due to automatic review settings November 13, 2026 16:57
Copilot AI reviewed Nov 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

codescene-delta-analysis[bot]
codescene-delta-analysis Bot approved these changes Nov 13, 2026
View reviewed changes

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@utkarsh232005
utkarsh232005 merged commit 2f88182 into KDM-cli:main Nov 13, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
+1 more reviewer
@codescene-delta-analysis codescene-delta-analysis[bot] codescene-delta-analysis[bot] approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: cli module: test module: ui multi-module review: easy review: medium size: M size: S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: WatchDashboard 'b' key fails to close logs overlay & pod restart lacks confirmation

2 participants

@utkarsh232005